linux: fix 'TLS PSK derivation fixes'#1042
Closed
hreinecke wants to merge 1 commit intolinux-nvme:masterfrom
Closed
linux: fix 'TLS PSK derivation fixes'#1042hreinecke wants to merge 1 commit intolinux-nvme:masterfrom
hreinecke wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
The patch 'TLS PSK derivation fixes' was a bit too eager in adding
the 'length' field to the HKDF label.
The NVMe TCP spec defines
Retained PSK = HKDF-Expand-Label(PRK, “HostNQN”, NQNh, Length(Configured PSK))
which according to RFC 8446 translates to:
HKDF-Expand(PRK, HkdfLabel, Length(Configured PSK))
and
HkdfLabel {
(u16) Length(Configured PSK)
"tls13 HostNQN"
NQNh
}
The previous patch would tread both the 'label' and the 'context' field
as an HkdfLabel, which is wrong.
Signed-off-by: Hannes Reinecke <[email protected]>
Collaborator
Author
|
Original patch had been reverted, so close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch 'TLS PSK derivation fixes' was a bit too eager in adding the 'length' field to the HKDF label.
The NVMe TCP spec defines
Retained PSK = HKDF-Expand-Label(PRK, “HostNQN”, NQNh, Length(Configured PSK))
which according to RFC 8446 translates to:
HKDF-Expand(PRK, HkdfLabel, Length(Configured PSK))
and
HkdfLabel {
(u16) Length(Configured PSK)
"tls13 HostNQN"
NQNh
}
The previous patch would tread both the 'label' and the 'context' field as an HkdfLabel, which is wrong.